Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many sync request for settings sync when toggling through themes. #138857

Closed
ShahanM opened this issue Dec 10, 2021 · 4 comments
Closed

Too many sync request for settings sync when toggling through themes. #138857

ShahanM opened this issue Dec 10, 2021 · 4 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@ShahanM
Copy link

ShahanM commented Dec 10, 2021

Issue Type: Bug

  1. Try to change themes by toggling through them and selecting to see the changes.
  2. Settings tries to sync on every call.
  3. Sync crashes because of too many requests in a short time.

Expectation: The sync shouldn't be sending a request on every change.

VS Code version: Code 1.62.3 (ccbaa2d, 2021-11-17T08:00:36.721Z)
OS version: Linux x64 5.13.0-7620-generic
Restricted Mode: No

@gjsjohnmurray
Copy link
Contributor

/duplicate of #91286

Maybe this new 1.63 feature avoids the problem (untested by me):

https://code.visualstudio.com/updates/v1_63#_preview-themes-before-installing

@ShahanM
Copy link
Author

ShahanM commented Dec 11, 2021

/duplicate of #91286

Maybe this new 1.63 feature avoids the problem (untested by me):

https://code.visualstudio.com/updates/v1_63#_preview-themes-before-installing

Thanks! I am sorry for the duplicate report. I used the report feature directly from VSCode. I will check out the patch.

@sandy081
Copy link
Member

@ShahanM Can you able to repro this? If so can you please share the following log:

F1 > Open View... > Log (Settings Sync)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

4 participants
@ShahanM @gjsjohnmurray @sandy081 and others