Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around Chrome implementing w3c's DOM Level3 Events section B.2.4 on Mac #1302

Closed
alexdima opened this issue Dec 14, 2015 · 1 comment
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded
Milestone

Comments

@alexdima
Copy link
Member

Chromium decided to implement section B.2.4 of DOM Level3 Events only on Mac.

Given the German (Swiss) keyboard layout:
420px-kb_swiss svg

This means that it is very difficult to figure out what actual physical key was pressed. E.g.:

  • when pressing 7, the keydown event we receive has keyCode:55
    • this is OK
  • when pressing Shift+7, the keydown we receive has shiftKey:true and keyCode: 191
    • this is unexpected, we should receive shiftKey:true and keyCode:55

To investigate if we can use the keyIdentifier and native-keymap to reverse their "helpful" keyCode massaging.

@alexdima alexdima added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority labels Dec 14, 2015
@alexdima alexdima self-assigned this Dec 14, 2015
@alexdima alexdima added this to the Dec 2015 milestone Dec 14, 2015
@alexdima
Copy link
Member Author

fyi @weinand

@egamma egamma closed this as completed in a17f22b Dec 15, 2015
@weinand weinand assigned weinand and unassigned alexdima Dec 16, 2015
@weinand weinand added the verified Verification succeeded label Dec 16, 2015
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants