Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow comparisons between Git timeline entries #116361

Closed
eamodio opened this issue Feb 10, 2021 · 2 comments
Closed

Allow comparisons between Git timeline entries #116361

eamodio opened this issue Feb 10, 2021 · 2 comments
Assignees
@eamodio
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders timeline Timeline view issues timeline-git Timeline view issues with Git history verification-needed Verification of issue is requested verified Verification succeeded
Milestone
February 2021

Comments

@eamodio
Copy link
Contributor

eamodio commented Feb 10, 2021

Ideally we should be able to multi-select timeline entries and compare the 2 ends of the selection. But even without multi-select we should allow the Select for Compare/Compare with Selected mechanism to provide a similar behavior.
@eamodio eamodio added feature-request Request for new features or functionality timeline Timeline view issues timeline-git Timeline view issues with Git history labels Feb 10, 2021
@eamodio eamodio added this to the February 2021 milestone Feb 10, 2021
@eamodio eamodio self-assigned this Feb 10, 2021
@kieferrm kieferrm mentioned this issue Feb 16, 2021
Closed
70 tasks
@eamodio eamodio mentioned this issue Feb 22, 2021
Closed
@eamodio
Copy link
Contributor Author

eamodio commented Feb 22, 2021

I've added support for the Select for Compare / Compare with Selected mechanism. And opened #117261 to track multi-select support.

@eamodio eamodio added the verification-needed Verification of issue is requested label Feb 22, 2021
@eamodio
Copy link
Contributor Author

eamodio commented Feb 22, 2021

To verify:

  1. Right-click on a Git timeline entry and choose Select for Compare
  2. Right-click on another Git timeline entry and choose Compare with Selected
  3. A diff should open between the chosen entries -- FYI the Select for Compare is always the left side of the diff.

@jrieken jrieken added the verified Verification succeeded label Feb 23, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@eamodio eamodio

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders timeline Timeline view issues timeline-git Timeline view issues with Git history verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
February 2021
Development

No branches or pull requests
3 participants
@eamodio @jrieken and others