Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions viewlet: 'Check for Extension Updates' should us a modal dialog to confirm #115039

Closed
egamma opened this issue Jan 26, 2021 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@egamma
Copy link
Member

egamma commented Jan 26, 2021

Testing #114922

Since the user initiated the action to check for extension update, the confirmation that no extension needs to be updated should be shown in a modal dialog (same as when you check for an update of VS Code).

image

@sandy081
Copy link
Member

@egamma It used to be dialog before and changed to notification because to be consistent with all other extensions update information messages which are shown as notifications - #98761

@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2021
@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions labels Mar 17, 2021
@sandy081 sandy081 added this to the March 2021 milestone Mar 17, 2021
@sandy081
Copy link
Member

I heard that this brought up in our stand up and want to revisit.

As said, this was made a notification because to be consistent with this action's behavior - to always show a notification to inform about updates.

I would like to change this behaviour as follows:

  • If there are updates, show the outdated extensions in the extensions view otherwise show a dialog that there are no updates

@sandy081 sandy081 reopened this Mar 17, 2021
@lramos15 lramos15 added the verified Verification succeeded label Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants
@egamma @lramos15 @sandy081 and others