Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrated terminal: Random laggy experience #109323

Closed
imWildCat opened this issue Oct 25, 2020 · 6 comments
Closed

Integrated terminal: Random laggy experience #109323

imWildCat opened this issue Oct 25, 2020 · 6 comments
Assignees
@deepak1556 @Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) electron Issues and items related to Electron terminal General terminal issues that don't fall under another label
Milestone
Backlog

Comments

@imWildCat
Copy link

imWildCat commented Oct 25, 2020 •
edited
Loading

  • VSCode Version and OS Version:
Version: 1.50.1
Commit: d2e414d9e4239a252d1ab117bd7067f125afd80a
Date: 2020-10-13T14:53:05.704Z
Electron: 9.2.1
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
OS: Darwin x64 20.1.0 - macOS 11.0 Beta (20A5395g)

Steps to Reproduce:

I don't think it can be reproduced easily on other machines.

  1. Open VSCode
  2. Type anything in the integrated terminal
  3. The lagging happens very frequently, about once per 10 ~ 30 seconds.

I can also see this if I open Developer Tools for profiling:
dev_tools

(I can upload this profiling log if needed)

Does this issue occur when all extensions are disabled?: Yes (I can always repro without any extension)
@Mokto
Copy link

Mokto commented Oct 28, 2020 •
edited
Loading

Thanks for the info @imWildCat.

Got the same issue and only when I run it through code ...

It appeared after I reinstalled a new Mac system with Big sur.

@imWildCat
Copy link
Author

Yeah, the Big Sur on my laptop was a fresh installation.

And it seems that I launched VSCode via command line as well.

@Tyriar
Copy link
Member

Tyriar commented Oct 29, 2020

Yes could you please attach the profile?

@Tyriar Tyriar added the info-needed Issue requires more information from poster label Oct 29, 2020
@Tyriar
Copy link
Member

Tyriar commented Oct 29, 2020

Looking at the profile it seems like maybe it's a bug in Node.js with Big Sur that some async process launches are happening synchronously or something?

image

@deepak1556 have you seen this happen elsewhere where exec ends up blocking the main thread for > 1s?

@Tyriar Tyriar added electron Issues and items related to Electron terminal General terminal issues that don't fall under another label bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Oct 29, 2020
@Tyriar Tyriar added this to the Backlog milestone Oct 29, 2020
@Tyriar Tyriar mentioned this issue Oct 29, 2020
Closed
@deepak1556
Copy link
Collaborator

/duplicate #105446

@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@deepak1556 deepak1556

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) electron Issues and items related to Electron terminal General terminal issues that don't fall under another label
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@deepak1556 @Tyriar @imWildCat @Mokto and others