Skip to content
This repository has been archived by the owner on Jan 6, 2025. It is now read-only.

The scroll bar style in the Shadow DOM of the component is not unified with the outside #258

Closed
rulelee opened this issue Oct 12, 2021 · 4 comments · Fixed by #338
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@rulelee
Copy link

rulelee commented Oct 12, 2021

image

@rulelee rulelee added the bug Something isn't working label Oct 12, 2021
@hawkticehurst
Copy link
Member

Thanks for the catch @rulelee! It looks like the text areas are using the default operating system scroll bar styling but I think it would make sense to change that to align with VS Code styling.

cc @daviddossett for design opinion?

@daviddossett
Copy link
Collaborator

Agreed—let's make sure we think about this globally, so to speak. I can imagine this coming up in other components/scenarios.

@hawkticehurst hawkticehurst added enhancement New feature or request bug Something isn't working and removed bug Something isn't working enhancement New feature or request labels Oct 12, 2021
@rulelee
Copy link
Author

rulelee commented Oct 15, 2021

My project is based on Vue, and the temporary solution is shown in the figure
Image
Image

@daviddossett
Copy link
Collaborator

Cool to see this, @rulelee! Would you have any interest in raising a PR for this? That would be a massive help for us 🤞

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants