Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reusing the Python shell after using quit() will keep running python commands #22944

Closed
andreamah opened this issue Feb 20, 2024 · 5 comments
Closed
Assignees
Labels
info-needed Issue requires more information from poster

Comments

@andreamah
Copy link

andreamah commented Feb 20, 2024

Testing #22926

  1. Run a command that will open the Python interpreter using shift+enter on a line.
  2. Manually run quit() in the python interpreter.
  3. Run a command again that will open the Python interpreter using shift+enter on a line.
  4. Notice that the interpreter doesn't open 🐛
  5. Furthermore, continually running shift+enter will keep adding to the command that it sends to the terminal.

In this case, I kept running time.sleep(1) in step 4 and 5.
image

This is still in the Python shell, btw.

@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Feb 20, 2024
@anthonykim1
Copy link

anthonykim1 commented Feb 23, 2024

@karrtikr Is there way we know which Terminal instance(s) have opened/launched Python REPL?

@github-actions github-actions bot added the info-needed Issue requires more information from poster label Feb 23, 2024
@anthonykim1 anthonykim1 removed the triage-needed Needs assignment to the proper sub-team label Feb 23, 2024
@karrtikr
Copy link

No, we can't directly tell if a terminal is a REPL as far as I know.

Although VS Code does give us access to commands run in the terminal. So technically if "quit()" is run, we can know that.

@karrtikr
Copy link

Monitoring that may be expensive though, so I suggest only doing it if enough users want this feature.

Copy link

github-actions bot commented Jun 7, 2024

Hey @anthonykim1, this issue might need further attention.

@andreamah, you can help us out by closing this issue if the problem no longer exists, or adding more information.

Copy link

github-actions bot commented Jul 8, 2024

Because we have not heard back with the information we requested, we are closing this issue for now. If you are able to provide the info later on, then we will be happy to re-open this issue to pick up where we left off.

Happy Coding!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 8, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

3 participants