Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Fix "Experimental Attach Configuration" snippet #88

Closed
weinand opened this issue Feb 15, 2017 · 3 comments
Closed

Fix "Experimental Attach Configuration" snippet #88

weinand opened this issue Feb 15, 2017 · 3 comments
Assignees
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Feb 15, 2017

I'm not sure what to do with node2's "Experimental Attach Configuration" snippet.

Since it uses a different port number than node-debug's attach snippet, we can only remove it if we make node-debug's attach snippet 'smart' (e.g. by removing the port attribute from the snippet and setting the correct port in the extension code based on the protocol).

Alternatively we could keep the snippet but change its name to "Attach to Port 9229" (vs. "Attach to Port 5828"). Or "Attach to Inspect Port (9229)" vs. "Attach to Debug Port (5858)".

Let me know what approach you prefer.

@roblourens
Copy link
Member

I think we should have two 'node' snippets, either named like "Attach to Port 9229", or like "Attach via Inspector Protocol" and "Attach via Legacy Protocol", with the port and protocol set.

@weinand
Copy link
Contributor Author

weinand commented Feb 16, 2017

@roblourens let's use the "Attach via Inspector Protocol" and "Attach via Legacy Protocol".

I've renamed my snippet to "Node.js: Attach via Legacy Protocol".
Let me know whether I should create a new snippet for "Attach via Inspector Protocol" on my side or whether you want to rename the existing one on your side.

@roblourens
Copy link
Member

I added one to the node-debug repo to be consistent. Also added the protocol field.

@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants