Adding multiple similar connections doesn't work correctly

[kburtram]

Steps to Reproduce:

1. Using the connection dialog, create a saved connection to a database on a server using SqlLogin
2. Using the connection dialog, create a saved connection to the server using Entra ID

Expected: Two distinct connections, one to DB and one to Server with different auth types. Clearly distinguishable in connection display name. Note: I'm not sure the repro needs to be this specific, probably any slightly ambiguous connections will have similar problems.

Actual: Two connections have same title, one of them clearly wrong. The contents in the below screenshot show both a DB and Server type connection (based on the subnodes), but the display names are identical. The second one being incorrect.

[kburtram]

This is similar repro when adding a connection from the MRU. I had two entries added to settings JSON for same the connection, one with only minimal details. They both show in Connections list but can't tell them apart.

Also, I don't think those generated profileNames should be put into the settings file since they are supposed to be auto-generated based on connection metadata. For example, if the metadata changes will the saved name be overridden with the new data & how can we tell the difference between the auto-gen name and user provided "friendly name"?

[Benjin]

I don't think those generated profileNames should be put into the settings file since they are supposed to be auto-generated based on connection metadata

Agreed; fixed as part of #18030

[Benjin]

Though I've seen this issue before, I haven't been able to repro it now that I'm digging into it. Can you try recording the exact steps you use to trigger this bug?

Win + Shift + R will trigger Windows' built-in screen recording tool for the easiest way to do that.

[Benjin]

This should be mostly resolved with #18684, though I still need to close some corner cases, like ensuring the displayname is differentiated.