Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difficulty differentiating cleaned and uncleaned cells #50

Open
Goodernews opened this issue May 24, 2023 · 3 comments
Open

Difficulty differentiating cleaned and uncleaned cells #50

Goodernews opened this issue May 24, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@Goodernews
Copy link

Environment data

  • VS Code version: 1.78.2
  • Data Wrangler Extension version: 0.8.0
  • Jupyter Extension version: v2023.4.1011241018
  • Python Extension version: v2023.8.0
  • OS: Windows_NT x64 10.0.2261
  • Pandas version: 2.0.1
  • Python and/or Anaconda version: 13.1
  • Type of virtual environment used: N/A

Expected behaviour

It is easy to disambiguate between reds and greens.

Actual behaviour

As someone with red-green colour-blindness, it is difficult to tell which cells are highlighted with specific shades of red or green. Specifically, cells where a subtle change is applied.

Base:
image

Protaopia:
image

Deuteranopia:
image

Tritanopia:
image

Steps to reproduce:

  1. Set VS Code to dark mode
  2. Run any data wrangler command that highlights cells
  3. Use a color-blind simulator or use the "Color filters" in the Windows settings.

Logs

N/A

@Goodernews
Copy link
Author

To clarify, I am using the built in Windows accessibility color filters.

@pwang347
Copy link
Member

pwang347 commented May 25, 2023

Hi @Goodernews, thanks for creating this issue!

We will look into this. In the meantime, please note that we do include the [+] and [-] icons in the header which should help with identifying which type of diff is shown for the column.

@pwang347 pwang347 added the bug Something isn't working label May 25, 2023
@jruales
Copy link
Contributor

jruales commented Jun 12, 2023

Related: microsoft/vscode#182173

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants