Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description of preferredPathSeparator setting is incorrect #12597

Closed
bobbrow opened this issue Aug 20, 2024 · 2 comments
Closed

Description of preferredPathSeparator setting is incorrect #12597

bobbrow opened this issue Aug 20, 2024 · 2 comments
Assignees
Labels
bug external Feature: Auto-complete fixed Check the Milestone for the release in which the fix is or will be available. Language Service Visual Studio Code Caused by (or depends on changes from) VS Code
Milestone

Comments

@bobbrow
Copy link
Member

bobbrow commented Aug 20, 2024

Environment

(irrelevant)

Bug Summary and Steps to Reproduce

We have a setting that supposedly controls the slash behavior for #include auto complete:
image

The setting description states that it is supposed to be the character used for path separators in the auto complete results. However, it doesn't appear that we add any separators for #include auto complete. I thought that we used to, but now it seems the setting is only used for paths returned via the code actions. I believe this setting was intended to cover more than just the #include auto complete case, but for now, I think we need to restore the behavior described in the setting and add separators as part of the #include auto complete feature.

Configuration and Logs

n/a

Other Extensions

No response

Additional context

No response

@browntarik
Copy link
Contributor

Not actionable due to bug that needs to be addressed by VS Code. Until it is addressed (microsoft/vscode#227012), we can't apply a reasonable fix.

@browntarik browntarik moved this from Triage to Done in cpptools Dec 18, 2024
@sean-mcmanus sean-mcmanus added external more votes needed Issues that have been postponed until more community members upvote it labels Dec 19, 2024
@sean-mcmanus sean-mcmanus closed this as not planned Won't fix, can't repro, duplicate, stale Dec 19, 2024
@bobbrow
Copy link
Member Author

bobbrow commented Dec 19, 2024

If we're not going to fix this, we should at least fix the setting's description.

@bobbrow bobbrow reopened this Dec 19, 2024
@bobbrow bobbrow changed the title preferredPathSeparator does not seem to be respected in #include auto complete Description of preferredPathSeparator setting is incorrect Dec 19, 2024
@browntarik browntarik moved this from Done to Pull Request in cpptools Dec 27, 2024
@browntarik browntarik moved this from Pull Request to Done in cpptools Dec 31, 2024
@sean-mcmanus sean-mcmanus added this to the 1.23.3 milestone Jan 8, 2025
@sean-mcmanus sean-mcmanus added fixed Check the Milestone for the release in which the fix is or will be available. and removed more votes needed Issues that have been postponed until more community members upvote it labels Jan 8, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug external Feature: Auto-complete fixed Check the Milestone for the release in which the fix is or will be available. Language Service Visual Studio Code Caused by (or depends on changes from) VS Code
Projects
Status: Done
Development

No branches or pull requests

3 participants