Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting with clang-format fails if it takes longer than 10 seconds (i.e. large enough file) #10213

Closed
sean-mcmanus opened this issue Dec 1, 2022 · 3 comments
Assignees
Labels
bug Feature: Code Formatting fixed Check the Milestone for the release in which the fix is or will be available. Language Service quick fix
Milestone

Comments

@sean-mcmanus
Copy link
Contributor

Use formatting with clang-format with a large file that takes > 10 seconds. Formatting will fail (might only repro on Windows?).

I think we may have added the 10 second timeout to work around a case where clang-format could get permanently stuck. Not sure if we need an adjustable timeout setting or what.

@bigbrett
Copy link

This is biting me right now as well. Does nobody work on large legacy code bases with long files!?!?. Repro'ed for me on Linux, so not just a Windows issue. Adjustable timeout, or at least a way to disable timeout, would be nice.

@sean-mcmanus sean-mcmanus self-assigned this Nov 11, 2024
@sean-mcmanus sean-mcmanus moved this to Pull Request in cpptools Nov 11, 2024
@sean-mcmanus sean-mcmanus added this to the 1.23.2 milestone Nov 11, 2024
@sean-mcmanus
Copy link
Contributor Author

@bigbrett Thanks for the comment. This issue should've been fixed a long time ago, but I think we just forgot about it.

@sean-mcmanus sean-mcmanus moved this from Pull Request to Done in cpptools Nov 11, 2024
@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Nov 11, 2024
@sean-mcmanus
Copy link
Contributor Author

@bigbrett Fixed with https://github.com/microsoft/vscode-cpptools/releases/tag/v1.23.2 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Feature: Code Formatting fixed Check the Milestone for the release in which the fix is or will be available. Language Service quick fix
Projects
Status: Done
Development

No branches or pull requests

2 participants