-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: scan kits from a folder #4191
Conversation
@std-microblock Thanks for your patience, we hope to assess this as soon as we can, but it may not be until after the holidays. Thank you for understanding. |
@std-microblock thank you so much for your contribution, we greatly appreciate it and your support! As a quick update, we plan to take this PR into our extension soon. As a side note, we plan to prioritize enhancements to CMake presets support moving forward (see issue: #4117). If there is a reason you prefer kits, we would love to know more in the issue I linked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of things that would improve this PR have been commented / requested. Otherwise, I think the changes look reasonable, please ping me when you've updated the PR based on my comments!
I'll look into the changes when I have spare time. |
I updated the code to share the logic, added context in the strings letting users know that it will be a recursive search, and I also added a progress notification for the accumulation of the folders to scan, since it could be a long operation someone selected a folder with lots of content. If you cancel, it will move forward with whatever was already scanned. |
The following changes are proposed:
The purpose of this change
Make the creation of kits easier.