Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: scan kits from a folder #4191

Merged
merged 5 commits into from
Jan 31, 2025
Merged

Conversation

std-microblock
Copy link
Contributor

The following changes are proposed:

  • A button to select a folder to scan kits in the kits selection menu.

The purpose of this change

Make the creation of kits easier.

@gcampbell-msft
Copy link
Collaborator

@std-microblock Thanks for your patience, we hope to assess this as soon as we can, but it may not be until after the holidays. Thank you for understanding.

@gcampbell-msft gcampbell-msft added this to the 1.20 milestone Jan 7, 2025
@gcampbell-msft gcampbell-msft self-assigned this Jan 8, 2025
@sinemakinci1
Copy link
Contributor

@std-microblock thank you so much for your contribution, we greatly appreciate it and your support! As a quick update, we plan to take this PR into our extension soon.

As a side note, we plan to prioritize enhancements to CMake presets support moving forward (see issue: #4117). If there is a reason you prefer kits, we would love to know more in the issue I linked.

Copy link
Collaborator

@gcampbell-msft gcampbell-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of things that would improve this PR have been commented / requested. Otherwise, I think the changes look reasonable, please ping me when you've updated the PR based on my comments!

@std-microblock
Copy link
Contributor Author

I'll look into the changes when I have spare time.

@gcampbell-msft
Copy link
Collaborator

I updated the code to share the logic, added context in the strings letting users know that it will be a recursive search, and I also added a progress notification for the accumulation of the folders to scan, since it could be a long operation someone selected a folder with lots of content. If you cancel, it will move forward with whatever was already scanned.

@gcampbell-msft gcampbell-msft merged commit 078d737 into microsoft:main Jan 31, 2025
4 checks passed
@Yingzi1234
Copy link
Collaborator

Verified this issue on cmake tools v1.20.50(pre-release), issue was fixed.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Blocked
Development

Successfully merging this pull request may close these issues.

5 participants