Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hiredis, redis-plus-plus #8840

Closed
RameshKandukuriB opened this issue Oct 31, 2019 · 3 comments
Closed

hiredis, redis-plus-plus #8840

RameshKandukuriB opened this issue Oct 31, 2019 · 3 comments
Assignees
@NancyLi1013
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR!

Comments

@RameshKandukuriB
Copy link

Is your feature request related to a problem? Please describe.
can't find, make and build hiredis/redis-plus-plus on windows 64 bit

Proposed solution
include hiredis/redis-plus-plus in the list.

Describe alternatives you've considered
build locally

Additional context
none
@RameshKandukuriB RameshKandukuriB added the category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed label Oct 31, 2019
@cbezault cbezault added category:new-port The issue is requesting a new library to be added; consider making a PR! and removed category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed labels Oct 31, 2019
@NancyLi1013 NancyLi1013 self-assigned this Nov 1, 2019
This was referenced Nov 1, 2019
Merged
Merged
Closed
@NancyLi1013
Copy link
Contributor

Hi @RameshKandukuriB thanks for posting this request.
These two ports have been added to vcpkg. Please update vcpkg and try to use them.

@RameshKandukuriB
Copy link
Author

Hi @NancyLi1013
Thanks for the update, however the windows build failed for me. See following

vcpkg_hiresis_failed
hiredis windows cmake failed

@NancyLi1013
Copy link
Contributor

Hi @RameshKandukuriB thanks for posting this issue.
Since the version of hiredis in vcpkg currently doesn't support Windows. So the behavior you encountered is intended.
I have submitted a PR #8902 to support Windows. But it can only support for static build on windows.
Please wait for some time and I will fix it in near future.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NancyLi1013 NancyLi1013

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cbezault @NancyLi1013 @RameshKandukuriB