Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libpq] define HAVE_CRYPTO_LOCK #8075

Closed
ian-p-cooke opened this issue Sep 6, 2019 · 0 comments · Fixed by #8076
Closed

[libpq] define HAVE_CRYPTO_LOCK #8075

ian-p-cooke opened this issue Sep 6, 2019 · 0 comments · Fixed by #8076
Assignees
@PhoebeHui
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist

Comments

@ian-p-cooke
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When writing a multi-threaded program where each thread has its own postgres connection sometimes the program would crash if SSL was enabled.

Proposed solution
Because libpq depends on openssl <1.1.0 then it must define HAVE_CRYPTO_LOCK to be thread-safe.

Describe alternatives you've considered
If you upgrade to openssl 1.1.0+ then you do not need to define HAVE_CRYPTO_LOCK.

Additional context
original issue with stacktrace, example, etc: diesel-rs/diesel#2162
@ian-p-cooke ian-p-cooke added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Sep 6, 2019
@ian-p-cooke ian-p-cooke mentioned this issue Sep 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PhoebeHui PhoebeHui

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

libpq requires HAVE_CRYPTO_LOCK for thread safety with openssl <1.1.0 ian-p-cooke/vcpkg
2 participants
@ian-p-cooke @PhoebeHui