Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[liblas] generated cmake config has absolute path to build machine #7749

Closed
pwm1234 opened this issue Aug 19, 2019 · 7 comments
Closed

[liblas] generated cmake config has absolute path to build machine #7749

pwm1234 opened this issue Aug 19, 2019 · 7 comments
Assignees
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@pwm1234
Copy link

pwm1234 commented Aug 19, 2019

Host Environment

  • OS: Ubuntu 18
  • Compiler: gcc 7.4

To Reproduce
Steps to reproduce the behavior:
./vcpkg install liblas
./vcpkg export liblas

Failure logs
share/cmake/libLAS/libls-depends-release.cmake has absolute paths in its definition of IMPORTED_LINK_INTERFACE_LIBRARIES that are wrong when exported.

@pwm1234 pwm1234 added the category:port-bug The issue is with a library, which is something the port should already support label Aug 19, 2019
@Neumann-A
Copy link
Contributor

are you setting VCPKG_BUILD_TYPE to release in your own triplet?

nevertheless the call to
vcpkg_fixup_cmake_targets
should be unconditional in the portfile of liblas

@pwm1234
Copy link
Author

pwm1234 commented Aug 19, 2019

I am just using the predefined triplet x64-linux. I will make the call to vcpkg_fixup_cmake_targets unconditional and see what changes.

@pwm1234
Copy link
Author

pwm1234 commented Aug 19, 2019

When I made the call to vcpkg_fixup_cmake_targets unconditional, I got the following error:

-- Using source at /home/local/SRI/e27290/projects/aspn-mapmatch/vcpkg/buildtrees/liblas/src/libLAS-1-3593c22f96
-- Configuring x64-linux-dbg
-- Configuring x64-linux-rel
-- Building x64-linux-dbg
-- Building x64-linux-rel
CMake Error at scripts/cmake/vcpkg_fixup_cmake_targets.cmake:53 (message):
'/home/local/SRI/e27290/projects/aspn-mapmatch/vcpkg/packages/liblas_x64-linux/debug/share/cmake/liblas'
 does not exist.
Call Stack (most recent call first):
 ports/liblas/portfile.cmake:42 (vcpkg_fixup_cmake_targets)
 scripts/ports.cmake:74 (include)

which goes away when I explicitly set VCPKG_BUILD_TYPE in the x64-linux triplet file. But some ports do not build correctly on linux when building only the release configuration.

So the problem seems to be that the debug build of liblas on linux is not making the expected/required folder?

@MVoz
Copy link
Contributor

MVoz commented Aug 19, 2019

default triplet? x64-linux?

./vcpkg install liblas:x64-linux
./vcpkg export liblas --triplet x64-linux

@pwm1234
Copy link
Author

pwm1234 commented Aug 20, 2019

Yes, I am using the default triplet, which is x64-linux, with no changes, which means VCPKG_BUILD_TYPE is not set.

@JackBoosY
Copy link
Contributor

I think IMPORTED_LINK_INTERFACE_LIBRARIES should use a relative path instead of an absolute path.

@JackBoosY
Copy link
Contributor

Hi @pwm1234, thanks for reporting this issue.
I've fixed this issue, please update vcpkg and rebuild liblas.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Development

No branches or pull requests

4 participants