Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Not Ready] [typespec-vs/typespec-vscode] Optimize err msg in typsespc extension #6144

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
b0ac596
Merge pull request #1 from microsoft/main
mzhongl524 Nov 22, 2024
3fcbe52
Merge branch 'microsoft:main' into main
mzhongl524 Nov 25, 2024
c109816
Merge branch 'microsoft:main' into main
mzhongl524 Dec 6, 2024
23f0108
Merge branch 'microsoft:main' into main
mzhongl524 Dec 12, 2024
6f04f65
Merge branch 'microsoft:main' into main
mzhongl524 Dec 23, 2024
688ca03
Merge branch 'microsoft:main' into main
mzhongl524 Dec 24, 2024
de3725e
Merge branch 'microsoft:main' into main
mzhongl524 Dec 30, 2024
8130ffb
Merge branch 'microsoft:main' into main
mzhongl524 Jan 3, 2025
beb6433
Merge branch 'microsoft:main' into main
mzhongl524 Jan 15, 2025
8a501f2
Merge branch 'microsoft:main' into main
mzhongl524 Jan 15, 2025
6e1ab2d
Merge branch 'microsoft:main' into main
mzhongl524 Jan 23, 2025
a35052f
Merge branch 'microsoft:main' into main
mzhongl524 Jan 24, 2025
be57c13
Merge branch 'microsoft:main' into main
mzhongl524 Feb 5, 2025
3a9dc7a
Merge branch 'microsoft:main' into main
mzhongl524 Feb 10, 2025
ad7dff7
Merge branch 'microsoft:main' into main
mzhongl524 Feb 10, 2025
f8e8f2f
Merge branch 'microsoft:main' into main
mzhongl524 Feb 12, 2025
7a700c8
Merge branch 'microsoft:main' into main
mzhongl524 Feb 14, 2025
5099583
Merge branch 'microsoft:main' into main
mzhongl524 Feb 18, 2025
a45dbd5
Merge branch 'microsoft:main' into main
mzhongl524 Feb 25, 2025
68cc91d
Merge branch 'microsoft:main' into main
mzhongl524 Feb 25, 2025
cc78e4a
Optimize the error messages that appear when using TypeSpec VS Code E…
mzhongl524 Feb 25, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/typespec-vs/src/Exceptions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ public TypeSpecServerNotFoundException(string fileName, Exception? innerExceptio
: base(string.Join("\n", new string[]
{
$"TypeSpec server executable was not found: '{fileName}' is not found. Make sure either:",
" - Node.js is installed locally and available in PATH.",
" - TypeSpec is installed locally at the root of this workspace or in a parent directory.",
" - TypeSpec is installed globally with `npm install -g @typespec/compiler'.",
" - TypeSpec server path is configured with https://typespec.io/docs/introduction/editor/vs/#configure."
Expand Down
1 change: 1 addition & 0 deletions packages/typespec-vscode/src/tsp-language-client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,7 @@ export class TspLanguageClient {
logger.error(
[
`TypeSpec server executable was not found: '${this.exe.command}' is not found. Make sure either:`,
" - Node.js is installed locally and available in PATH.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we can know the command is "node", please update to only add the line when the command is "node". thx

` - TypeSpec is installed locally at the root of this workspace ("${workspaceFolder}") or in a parent directory.`,
" - TypeSpec is installed globally with `npm install -g @typespec/compiler'.",
" - TypeSpec server path is configured with https://typespec.io/docs/introduction/editor/vscode/#configure.",
Expand Down
Loading