Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Settings> Open/Close Navigation]: Neither name is descriptive nor changing name is announced by Screen reader for 'Open/Close Navigation' button. #11250

Closed
Tracked by #9990
ghost opened this issue Sep 16, 2021 · 7 comments
Labels
A11yCO Accessibility tracking A11ySev3 Accessibility tracking A11yWCAG Accessibility tracking Area-Accessibility Issues related to accessibility HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-External For issues that are outside this codebase Tracking-External This bug isn't resolved, but it's following an external workitem. WindowsTerminal_Win32

Comments

@ghost
Copy link

ghost commented Sep 16, 2021

Windows Terminal version (or Windows build number)

1.10.2383.0

Other Software

Test Environment:
OS: Windows 11 Version 21H2 (OS Build 22000.168)
Screen Reader: Narrator
Tool: Accessibility Insight for Windows

Steps to reproduce

Repro Steps:

  1. Open Windows Terminal.
  2. Open Settings page using "Ctrl + ',' ".
  3. Open Narrator using 'Win + Ctrl + Enter' key.
  4. Navigate to 'Open/Close Navigation', Observe the issue.
  5. Then activate 'Open/Close Navigation' button and observe the issue.

User Experience:
Screen Reader user are impacted here as they will not be able to know whether navigation is open or close as changing name is not announced to them in addition to that name of the control is confusing when compared to visual view.

Guideline Reference:
https://www.w3.org/WAI/WCAG21/Understanding/info-and-relationships

Attachments:
Neither name is descriptive nor changing name.zip

Expected Behavior

Screen Reader should announce 'Expand/Collapse Navigation View' as name for control and when user activate it Screen Reader should announce the changing name of the button.

Actual Behavior

Neither name is descriptive nor changing name is announced by Screen reader for 'Open/Close Navigation' button. Screen Reader is announcing 'Open/Close Navigation' which is incorrect and When user activate 'Open/Close navigation' button Screen Reader remain Silent.

Observation: Same issue repro with NVDA Screen Reader.

@ghost ghost added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-Accessibility Issues related to accessibility HCL-E+D Accessibility tracking A11yWCAG Accessibility tracking HCL-WindowsTerminal Accessibility tracking A11yCO Accessibility tracking A11ySev3 Accessibility tracking Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Sep 16, 2021
@zadjii-msft zadjii-msft added the Priority-3 A description (P3) label Sep 16, 2021
@DHowett
Copy link
Member

DHowett commented Sep 16, 2021

This looks like the upstream issue microsoft/microsoft-ui-xaml#3494, which they have accepted into their backlog.

@DHowett DHowett added Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Sep 16, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Sep 16, 2021
@ghost
Copy link
Author

ghost commented Sep 21, 2021

We are tracking this bug here microsoft/microsoft-ui-xaml#3494 so closing this bug as External

@ghost ghost closed this as completed Sep 21, 2021
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Sep 21, 2021
@ghost
Copy link
Author

ghost commented May 3, 2022

Issue is still repro on below environment.

Test Environment:
OS: Windows 11 Version 21H2 (OS Build 22598.200)
Application: Window Terminal Preview
App Version: 1.13.10984.0
Screen Reader: Narrator

@ghost ghost added Tracking-External This bug isn't resolved, but it's following an external workitem. and removed Needs-Tag-Fix Doesn't match tag requirements labels May 3, 2022
@DHowett DHowett reopened this May 3, 2022
@carlos-zamora carlos-zamora added the Resolution-External For issues that are outside this codebase label Oct 19, 2022
@carlos-zamora
Copy link
Member

@v-rpundir
I'm a bit confused here. The bug is caused by microsoft/microsoft-ui-xaml#3494.
Since the XAML team has accepted the bug, can't we close this bug?

@ghost
Copy link
Author

ghost commented Oct 20, 2022

@carlos-zamora Here is summary of our current External process we follow in this case:

  1. Your team can Resolve/Close the bug if the bug has external dependency by mentioning the External team's name or contact.
  2. Then we will contact the external testing team to get Tracking bug ID (we prefer VSO Tracking ID instead of GitHub as it has Proper Tracking and External team should have to fix it to maintain its Product Compliance) which is XAML in this case.
  3. After we get Tracking ID, we will mention it in this bug.
  4. When External bug gets closed with A11yTTValidated, we will check this bug and in case it repro's we will reactivate/reopen it and if external bug closed with reason By Design/Won't Fix, we will close this bug.

A11yTTValidated: When the bug has this tag it means it is closed now from Testing team and no further action is needed in the bug so even if the Product team close the bug for their reference, it will not be considered as closed from testing team side.

I hope this helps in clearing the bug external Process.

Thanks :):

@ghost
Copy link
Author

ghost commented Oct 20, 2022

As now XAML team is tracking bugs in VSO we will get VSO tracking ID for this bug.

@ghost
Copy link
Author

ghost commented Oct 20, 2022

XAML VSO Tracking ID: Bug 41570653: [WinUI Accessibility-> Left Navigation Pane]: No success information announced by screen reader, when user invokes open/close navigation button.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11yCO Accessibility tracking A11ySev3 Accessibility tracking A11yWCAG Accessibility tracking Area-Accessibility Issues related to accessibility HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-External For issues that are outside this codebase Tracking-External This bug isn't resolved, but it's following an external workitem. WindowsTerminal_Win32
Projects
None yet
Development

No branches or pull requests

4 participants