Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add success message when scans complete without results #26

Merged

Conversation

winstliu
Copy link
Member

Fixes #25. The real change is on L173.

Success message showing "No results found after running 1 scan"

@EasyRhinoMSFT
Copy link
Collaborator

EasyRhinoMSFT commented Dec 29, 2023

{

Does this file actually need to be in the repo? #ByDesign


Refers to: package-lock.json:1 in f39dd6c. [](commit_id = f39dd6c, deletion_comment = False)

@EasyRhinoMSFT
Copy link
Collaborator

{

nm I see your comment


In reply to: 1872261876


Refers to: package-lock.json:1 in f39dd6c. [](commit_id = f39dd6c, deletion_comment = False)

Copy link
Collaborator

@EasyRhinoMSFT EasyRhinoMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@EasyRhinoMSFT EasyRhinoMSFT merged commit 3178c3c into main Feb 29, 2024
@winstliu winstliu deleted the user/winstonliu/add-success-message-when-no-results branch February 29, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SARIF SAST Scans Tab not showing scan results
2 participants