-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Goto definition goes to stub files instead of actual definitions #949
Comments
#65 was about filtering the navigation, so that was closed. These above issues were with source mapping (mapping pyi contents to py content) and required a different fix. All of the above will work in the next version, except |
whow! Thats great news!! 🤩 So the attrgetter stub with the |
That stub is sourced from typeshed and would need to be fixed there. I don't know what the history of that stub is to know if it was intentional or not. I've seen that sort of thing a few times. |
This issue has been fixed in version 2021.2.4, which we've just released. You can find the changelog here: https://github.com/microsoft/pylance-release/blob/main/CHANGELOG.md#202124-24-february-2021 |
@cloud-yu Please file a new issue with the bug template; your issue is likely unrelated to this old, closed issue. |
Seems like the issue (#65) has not been solved entirely :/
Examples from the old report still show "some" preference to the stub files although there are source files in place.:
performing Goto Definition/Goto Declaration DOES work on
HTTPStatus
but always goes to Declaration onhttp
andGATEWAY_TIMEOUT
neither
operator
norattrgetter
bring you to the source code definition on Goto Definition or Goto Declarationall goto the Declaration stub whatever I do
only
quote
works here.Expected
IF there is source code
Goto Definition brings you to the source code
.py
Goto Declaration opens the stub
.pyi
Environment data
Version: 1.54.0-insider (user setup)
Commit: 93f705ab40b37aade9d3b5165ed09114a8c87ac9
Date: 2021-02-11T05:44:31.644Z (2 days ago)
Electron: 11.2.3
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: 8.7.220.31-electron.0
OS: Windows_NT x64 10.0.19042
The text was updated successfully, but these errors were encountered: