Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pandas to_dict has wrong return type for most orient arguments #448

Closed
Dr-Irv opened this issue Oct 1, 2020 · 1 comment
Closed

pandas to_dict has wrong return type for most orient arguments #448

Dr-Irv opened this issue Oct 1, 2020 · 1 comment
Assignees
Labels
fixed in next version (main) A fix has been implemented and will appear in an upcoming version typestub Issue relating to our bundled type stubs

Comments

@Dr-Irv
Copy link

Dr-Irv commented Oct 1, 2020

Environment data

  • Language Server version: 2020.9.7
  • OS and version: Windows 10
  • Python version (& distribution if applicable, e.g. Anaconda): Anaconda Python 3.7.5

Expected behaviour

No error

Actual behaviour

from typing import Dict, Any
import pandas as pd


df = pd.DataFrame({"x": [1, 2, 3]})

dic: Dict[str, Any] = df.to_dict(orient="split")

reports

Expression of type "List[Dict[_str, Any]]" cannot be assigned to declared type "Dict[str, Any]"
  "List[Dict[_str, Any]]" is incompatible with "Dict[str, Any]"

Issue here is that the return type of to_dict depends on the orient argument.

Possible solution:

diff frame.pyi.ORIG frame.pyi
202c202
<         self, orient: Union[_str, Literal["dict", "list", "series", "split", "records", "index"]] = ..., into: Hashable = ...,
---
>         self, orient: Literal["records"] = ..., into: Hashable = ...,
203a204,207
>     @overload
>     def to_dict(
>         self, orient: Union[_str, Literal["dict", "list", "series", "split", "index"]] = ..., into: Hashable = ...,
>     ) -> Dict[_str, Any]: ...
@github-actions github-actions bot added the triage label Oct 1, 2020
@jakebailey jakebailey added the typestub Issue relating to our bundled type stubs label Oct 2, 2020
@github-actions github-actions bot removed the triage label Oct 2, 2020
@jakebailey jakebailey added the fixed in next version (main) A fix has been implemented and will appear in an upcoming version label Oct 6, 2020
@jakebailey
Copy link
Member

This issue has been fixed in version 2020.10.0, which we've just released. You can find the changelog here: https://github.com/microsoft/pylance-release/blob/master/CHANGELOG.md#2020100-7-october-2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed in next version (main) A fix has been implemented and will appear in an upcoming version typestub Issue relating to our bundled type stubs
Projects
None yet
Development

No branches or pull requests

3 participants