Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive of incompatible override #2430

Closed
Azureblade3808 opened this issue Mar 3, 2022 · 3 comments
Closed

False positive of incompatible override #2430

Azureblade3808 opened this issue Mar 3, 2022 · 3 comments
Labels
bug Something isn't working fixed in next version (main) A fix has been implemented and will appear in an upcoming version

Comments

@Azureblade3808
Copy link

  • Language Server version: 2022.2.5-pre-1
  • OS and version: Windows 7
  • Python version (& distribution if applicable, e.g. Anaconda): 3.8.12 Anaconda

Sample code

from __future__ import annotations

from typing import Any

class Base:
    def f(self, *, kwarg0: Any) -> None:
        ...

class Derived(Base):
    def f(self, arg0: Any = ..., *, kwarg0: Any) -> None:
        ...

Expected behavior

No error/warning.

Actual behavior

image

@erictraut
Copy link
Contributor

Thanks for the bug report. I've created a tracking bug in the pyright repo.

@erictraut erictraut added bug Something isn't working and removed triage labels Mar 3, 2022
@erictraut
Copy link
Contributor

This will be fixed in the next release.

@erictraut erictraut added the fixed in next version (main) A fix has been implemented and will appear in an upcoming version label Mar 5, 2022
@bschnurr
Copy link
Member

bschnurr commented Mar 9, 2022

This issue has been fixed in version 2022.3.1, which we've just released. You can find the changelog here: CHANGELOG.md

@bschnurr bschnurr closed this as completed Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed in next version (main) A fix has been implemented and will appear in an upcoming version
Projects
None yet
Development

No branches or pull requests

3 participants