Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

204 responses handling in ruby #1656

Closed
Tracked by #1049
baywet opened this issue Jun 23, 2022 · 1 comment
Closed
Tracked by #1049

204 responses handling in ruby #1656

baywet opened this issue Jun 23, 2022 · 1 comment
Labels
enhancement New feature or request Ruby

Comments

@baywet
Copy link
Member

baywet commented Jun 23, 2022

related #1410

Two main cases are possible:

The endpoint is described to only return 204, in which case we should have a request adapter method that returns void (might not be required due to the dynamic nature of the language making it possible to reuse existing methods). In which case the executor method generation needs to be updated like other languages.

The endpoint is described to return a success status code, but we get a 204 response at runtime. In which case the request adapter implementation should be updated so it doesn't try to access the response body to deserialize it, and simply to return null instead.

@baywet baywet added enhancement New feature or request Ruby labels Jun 23, 2022
@baywet
Copy link
Member Author

baywet commented Sep 8, 2022

superseded by #1827

@baywet baywet closed this as completed Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Ruby
Projects
None yet
Development

No branches or pull requests

2 participants