Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why deepcopy __dict__ to serialize to json? #16

Open
melsabagh opened this issue Oct 9, 2022 · 0 comments
Open

Why deepcopy __dict__ to serialize to json? #16

melsabagh opened this issue Oct 9, 2022 · 0 comments

Comments

@melsabagh
Copy link

The deepcopy of the instance __dict__ during serialization at the following line seems unnecessary:

dict = copy.deepcopy(dict)

I have benchmarked this and it is also a serious bottleneck when serializing large objects. Is there a reason behind creating a deep copy here instead of a shallow copy?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant