Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#627 expired SAS tokens] Call the runner directly from the task command-line #630

Closed
BMurri opened this issue Feb 29, 2024 · 0 comments · Fixed by #735
Closed

[#627 expired SAS tokens] Call the runner directly from the task command-line #630

BMurri opened this issue Feb 29, 2024 · 0 comments · Fixed by #735
Labels
enhancement New feature or request TES Priority: P2 Groomed to a Priority 2 issue
Milestone

Comments

@BMurri
Copy link
Collaborator

BMurri commented Feb 29, 2024

Problem:
Before we had a runner binary, we had to do all sorts of things to manipulate the compute node and files on it to run the task's command-line and upload trace and metrics files, including scrubbing the compute nodes before the next task started, all to avert several issues with the way that azure batch handles resource files, container images, and tasks.

Now that we have the runner, which has already taken on the most major of those responsibilities, it is time to give it the rest of them and eliminate the batch script file (and thus the requirement we have on bash) entirely.

Solution:

  1. Remove src/TesApi.Web/scripts/clean-executor.sh, src/TesApi.Web/scripts/task-run.sh, & src/TesApi.Web/BatchNodeScriptBuilder.cs.
  2. Incorporate still-relevant activities from the eliminated code into the runner itself (making use of the task json as appropriate, if needed). That list is TBD, but should include uploading the metrics.txt and the stderr.txt & stdout.txt files from batch before exiting, even when failures have occurred.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request TES Priority: P2 Groomed to a Priority 2 issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant