Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid enum values cause segmentation fault. #334

Closed
gitmodimo opened this issue Nov 6, 2024 · 2 comments
Closed

Invalid enum values cause segmentation fault. #334

gitmodimo opened this issue Nov 6, 2024 · 2 comments

Comments

@gitmodimo
Copy link

gitmodimo commented Nov 6, 2024

When enum vale is out of range due to being uninitialized of any other reason the library segfaults.

The fix is easy and I think the library should not segfault on bad/uninitialized enum value.

Edit:
Tests after fix fail due to bad results not by segfault.

@wravery
Copy link
Contributor

wravery commented Nov 6, 2024

The proposed fix looks good, want to spin up a PR? I don't want to bypass the CLA and such by just integrating it myself, but if the PR targets either main or next I can make sure it's merged for v5.0.

This was referenced Nov 7, 2024
@gitmodimo
Copy link
Author

PR ready . LMK if you want me to do one for this.

@wravery wravery closed this as completed in 81abdc6 Dec 8, 2024
wravery added a commit that referenced this issue Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants