Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vectorize lexicographical_compare, lexicographical_compare_three_way #3998

Closed
AlexGuteniev opened this issue Aug 28, 2023 · 3 comments · Fixed by #4552
Closed

vectorize lexicographical_compare, lexicographical_compare_three_way #3998

AlexGuteniev opened this issue Aug 28, 2023 · 3 comments · Fixed by #4552
Labels
fixed Something works now, yay! performance Must go faster

Comments

@AlexGuteniev
Copy link
Contributor

AlexGuteniev commented Aug 28, 2023

Some parts are similar to what we have

  • There's already memcmp optimization, so the predicate classification can be reused
  • The elements classification can be reused from min/max_element optimization
  • The wrappers for intrinsics can also be reused from min/max_element optimization

Scope

@CaseyCarter CaseyCarter added the performance Must go faster label Aug 29, 2023
@CaseyCarter
Copy link
Contributor

ranges::lexicographical_compare still supports comparing two infinite ranges, the change is that it won't try to pass them to memcmp.

@AlexGuteniev
Copy link
Contributor Author

ranges::lexicographical_compare still supports comparing two infinite ranges

Yes, I meant support by optimization, not general support.

@AlexGuteniev
Copy link
Contributor Author

I struck floats, as on more thought it doesn't seem to make much sense to do lexicographical comparison of array of floats.
I also struck infinite ranges, guess we're not doing that anymore.

@StephanTLavavej StephanTLavavej added the fixed Something works now, yay! label Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed Something works now, yay! performance Must go faster
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants