Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update slicing of OpenAPI document to include path parameters #834

Closed
irvinesunday opened this issue Apr 19, 2022 · 8 comments · Fixed by #943
Closed

Update slicing of OpenAPI document to include path parameters #834

irvinesunday opened this issue Apr 19, 2022 · 8 comments · Fixed by #943
Assignees
Labels
priority:p1 High priority but not blocking. Causes major but not critical loss of functionality SLA <=7days type:bug A broken experience
Milestone

Comments

@irvinesunday
Copy link
Contributor

irvinesunday commented Apr 19, 2022

This setting in the conversion lib enables us to declare path parameters at the path item level when converting from CSDL to OpenAPI:
DeclarePathParametersOnPathItem=true.
This setting is set to true in Hidi when converting from CSDL to OpenAPI. When slicing the OpenAPI document to obtain a subset document in the OpenAPIFilterService, the OpenApiPathItem parameters from the main OpenAPI document don't get copied over to the subset document.

@irvinesunday irvinesunday added the type:enhancement Enhancement request targeting an existing experience label Apr 19, 2022
@irvinesunday irvinesunday self-assigned this Apr 19, 2022
@CarolKigoonya CarolKigoonya added type:bug A broken experience and removed type:enhancement Enhancement request targeting an existing experience labels Apr 26, 2022
@ddyett
Copy link
Member

ddyett commented Apr 28, 2022

@adhiambovivian @irvinesunday @CarolKigoonya how far are we from fixing this. My understanding is that it's blocking PowerShell based on the comments in Irvine's PR above.

//cc @peombwa

@irvinesunday
Copy link
Contributor Author

@adhiambovivian @irvinesunday @CarolKigoonya how far are we from fixing this. My understanding is that it's blocking PowerShell based on the comments in Irvine's PR above.

//cc @peombwa

We have reverted this setting in DevX API to unblock PowerShell in the interim.

@darrelmiller darrelmiller self-assigned this May 5, 2022
@adhiambovivian adhiambovivian added this to the 1.4 milestone May 11, 2022
@darrelmiller darrelmiller removed their assignment May 11, 2022
@CarolKigoonya
Copy link
Collaborator

We are working on design to address the issue, but reverting should have unblocked PowerShell @peombwa and @maisarissi please confirm

@adhiambovivian adhiambovivian added the priority:p1 High priority but not blocking. Causes major but not critical loss of functionality SLA <=7days label May 16, 2022
@peombwa
Copy link
Contributor

peombwa commented May 16, 2022

@CarolKigoonya, I can confirm that the revert unblocked PowerShell!

@darrelmiller
Copy link
Member

@baywet I'm assuming this issue is still affecting Kiota self-serve usage.

@baywet
Copy link
Member

baywet commented Jul 5, 2022

correct

@irvinesunday
Copy link
Contributor Author

We are working on this resolution
cc: @MaggieKimani1

@baywet
Copy link
Member

baywet commented Jul 15, 2022

To be more specific, I believe the impact is wider than just slicing, even the current full beta/v1 descriptions with have in the metadata repo are missing the user-id path parameter for '/users/{user-id}'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:p1 High priority but not blocking. Causes major but not critical loss of functionality SLA <=7days type:bug A broken experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants