Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: refactor ToIdentifier() to normalize flaggable enums #2156

Merged
merged 15 commits into from
Feb 20, 2025
Merged

fix: refactor ToIdentifier() to normalize flaggable enums #2156

merged 15 commits into from
Feb 20, 2025

Conversation

MaggieKimani1
Copy link
Contributor

@MaggieKimani1 MaggieKimani1 commented Feb 18, 2025 •
edited by baywet
Loading

  • Adds support for normalizing flaggable enums by returning an array of strings
  • Supports casting of type arrays to the flaggable enum type
  • Adds tests to validate

Fixes #2078
Fixes #1924

@baywet baywet mentioned this pull request Feb 19, 2025
Closed
baywet
baywet requested changes Feb 20, 2025
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes!
A couple of additional remarks for performance.

Note: we could also use frozen dictionary for the static reference but I'm not sure the extra dependency is worth it.

MaggieKimani1 and others added 4 commits February 20, 2025 17:21
@MaggieKimani1 @baywet
Update src/Microsoft.OpenApi/Extensions/OpenApiTypeMapper.cs
fe50da3 
Co-authored-by: Vincent Biret <vibiret@microsoft.com>
@MaggieKimani1 @baywet
Update src/Microsoft.OpenApi/Extensions/OpenApiTypeMapper.cs
cbb1407 
Co-authored-by: Vincent Biret <vibiret@microsoft.com>
@MaggieKimani1 @baywet
Update src/Microsoft.OpenApi/Extensions/OpenApiTypeMapper.cs
fe19bfb 
Co-authored-by: Vincent Biret <vibiret@microsoft.com>
@MaggieKimani1
chore: clean up
ee43027
@baywet
chore: removes redundant check
844b9b1 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet baywet disabled auto-merge February 20, 2025 16:48
@baywet baywet enabled auto-merge (squash) February 20, 2025 16:49
@baywet
chore: cleans up api surface
3d7aa58 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet baywet merged commit b80e934 into main Feb 20, 2025
10 of 13 checks passed
@baywet baywet deleted the fix/lowercase-json-schema-type-values branch February 20, 2025 16:54
@release-please release-please bot mentioned this pull request Feb 20, 2025
Merged
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
73.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darrelmiller darrelmiller darrelmiller left review comments

@baywet baywet baywet approved these changes

@irvinesunday irvinesunday Awaiting requested review from irvinesunday irvinesunday is a code owner

@gavinbarron gavinbarron Awaiting requested review from gavinbarron gavinbarron is a code owner

@millicentachieng millicentachieng Awaiting requested review from millicentachieng millicentachieng is a code owner

@andrueastman andrueastman Awaiting requested review from andrueastman andrueastman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@MaggieKimani1 @darrelmiller @baywet