Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read annotations on MediaEntity paths that are structural paths #399

Closed
andrueastman opened this issue Jul 3, 2023 · 0 comments · Fixed by #470
Closed

Read annotations on MediaEntity paths that are structural paths #399

andrueastman opened this issue Jul 3, 2023 · 0 comments · Fixed by #470
Assignees
Labels
priority:p1 High priority but not blocking. Causes major but not critical loss of functionality SLA <=7days
Milestone

Comments

@andrueastman
Copy link
Member

Taking a look at the reference document at https://learn.microsoft.com/en-us/graph/api/driveitem-get-content-format?view=graph-rest-1.0&tabs=http

The /content path supports taking a queryparameter of the name format. As this is a structural property that returns a stream type, it is resolved to the MediaEntityOperationalHandler

https://github.com/microsoft/OpenAPI.NET.OData/blob/master/src/Microsoft.OpenApi.OData.Reader/Operation/MediaEntityOperationalHandler.cs

Due to the path being a structural type, the annotations are not read during the conversion process as annotations are read if the path is a NavigationPropertyPath and not if its a structural path. (Only the description is read)

Due to this, adding annotations makes is not possible to add query parameters to this path.

Related to microsoftgraph/msgraph-sdk-dotnet#1621

@andrueastman andrueastman added the priority:p1 High priority but not blocking. Causes major but not critical loss of functionality SLA <=7days label Nov 20, 2023
@irvinesunday irvinesunday self-assigned this Nov 30, 2023
@irvinesunday irvinesunday added this to the OData: 1.6 milestone Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:p1 High priority but not blocking. Causes major but not critical loss of functionality SLA <=7days
Projects
None yet
2 participants