Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AADGroupEligibilitySchedule should not use DisplayName as key #5800

Open
mpoulson opened this issue Feb 18, 2025 · 0 comments
Open

AADGroupEligibilitySchedule should not use DisplayName as key #5800

mpoulson opened this issue Feb 18, 2025 · 0 comments

Comments

@mpoulson
Copy link
Contributor

@sandrola and @NikCharlebois the Resource AADGroupEligibilitySchedule uses DisplayName as Key. This is different than AADGroupEligibilitySchedule which uses UPN or group name. Display Name is not a unique value and is not the best option.

I propose given AADGroupEligibilitySchedule was broken until my current changes that we also take the opportunity to refactor how it work.

My recommendation

  1. Follow same model as AADGroupEligibilitySchedule to allow User (UPN), Group (Group Name) as Principal
  2. Allow setting justification with the entry

Separately, I hope we can add PIM-Group Settings as a future resource type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant