From fcb6b42dcacbd8f8b22fe28d8d41bca4f282fe0f Mon Sep 17 00:00:00 2001 From: Eu Jing Chua Date: Wed, 10 Jul 2024 19:17:51 +0000 Subject: [PATCH 1/2] Update azure credential to be more flexible --- mlos_bench/mlos_bench/services/remote/azure/azure_auth.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mlos_bench/mlos_bench/services/remote/azure/azure_auth.py b/mlos_bench/mlos_bench/services/remote/azure/azure_auth.py index b1e484c009f..f07ad54669a 100644 --- a/mlos_bench/mlos_bench/services/remote/azure/azure_auth.py +++ b/mlos_bench/mlos_bench/services/remote/azure/azure_auth.py @@ -65,8 +65,8 @@ def __init__(self, self._token_expiration_ts = datetime.now(UTC) # Typically, some future timestamp. # Login as ourselves - self._cred: Union[azure_id.AzureCliCredential, azure_id.CertificateCredential] - self._cred = azure_id.AzureCliCredential() + self._cred: Union[azure_id.DefaultAzureCredential, azure_id.CertificateCredential] + self._cred = azure_id.DefaultAzureCredential() # Verify info required for SP auth early if "spClientId" in self.config: From feb5ae202bd665a7afe5277376f17a28c6101c13 Mon Sep 17 00:00:00 2001 From: Eu Jing Chua Date: Wed, 10 Jul 2024 19:23:14 +0000 Subject: [PATCH 2/2] Update comments --- mlos_bench/mlos_bench/services/remote/azure/azure_auth.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mlos_bench/mlos_bench/services/remote/azure/azure_auth.py b/mlos_bench/mlos_bench/services/remote/azure/azure_auth.py index f07ad54669a..934f27adcd6 100644 --- a/mlos_bench/mlos_bench/services/remote/azure/azure_auth.py +++ b/mlos_bench/mlos_bench/services/remote/azure/azure_auth.py @@ -64,7 +64,7 @@ def __init__(self, self._access_token = "RENEW *NOW*" self._token_expiration_ts = datetime.now(UTC) # Typically, some future timestamp. - # Login as ourselves + # Login as the first identity available, usually ourselves or a managed identity self._cred: Union[azure_id.DefaultAzureCredential, azure_id.CertificateCredential] self._cred = azure_id.DefaultAzureCredential()