Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing indicator should not show up on oneself #2942

Closed
compulim opened this issue Feb 24, 2020 · 1 comment · Fixed by #2950
Closed

Typing indicator should not show up on oneself #2942

compulim opened this issue Feb 24, 2020 · 1 comment · Fixed by #2950
Assignees
Labels
bug Indicates an unexpected problem or an unintended behavior.

Comments

@compulim
Copy link
Contributor

Probably related to recent typing indicator PR #2912.

Version

master as of today.

Describe the bug

When sendTyping is set to true, the typing indicator should not show up for oneself.

Steps to reproduce

  1. Go to https://microsoft.github.io/BotFramework-WebChat/05.custom-components/b.send-typing-indicator/
  2. Type something

Expected behavior

The typing indicator should not show up.

Today, the typing indicator show up.

Additional context

[Bug]

@compulim compulim added bug Indicates an unexpected problem or an unintended behavior. Pending customer-reported Required for internal Azure reporting. Do not delete. Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Required for internal reporting. Do not delete. labels Feb 24, 2020
@tdurnford
Copy link
Contributor

tdurnford commented Feb 24, 2020

@compulim I don't believe there is an issue with the typing indicator. The echo typing command makes Mock Bot echo typing activities sent from the user, so the typing activities that are being displayed are for the bot - not the user. If you set sendTypingIndicator to true and don't send the the echo typing command, the typing indicator is not displayed when the user types.

// When "echo-typing" is enabled on MockBot, it will echo back all typing indicator send from the user.
const store = window.WebChat.createStore({}, ({ dispatch }) => next => action => {
  if (action.type === 'DIRECT_LINE/CONNECT_FULFILLED') {
    dispatch({ type: 'WEB_CHAT/SEND_MESSAGE', payload: { text: 'echo-typing' } });
  }

  return next(action);
});

@tdurnford tdurnford removed Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. labels Feb 24, 2020
@compulim compulim added the R8 label Feb 25, 2020
@compulim compulim self-assigned this Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or an unintended behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants