Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptive Cards do not inherit style options properly #2565

Closed
compulim opened this issue Nov 6, 2019 · 0 comments · Fixed by #2566
Closed

Adaptive Cards do not inherit style options properly #2565

compulim opened this issue Nov 6, 2019 · 0 comments · Fixed by #2566
Assignees
Labels
bug Indicates an unexpected problem or an unintended behavior.

Comments

@compulim
Copy link
Contributor

compulim commented Nov 6, 2019

Screenshots

image

Version

4.6.0

Describe the bug

When we are creating Adaptive Cards host config, we are not using a default-merged style options.

If the dev did not specify style options, we show the card title in #000 color (inherited from default style options).

But if the dev specify style options of { richCardWrapTitle: true }, we show the card title in #333 color. This is because we did not merge default style options before creating a new Adaptive Cards host config. Thus, we are not using #000 as specified in default style options. Instead, we are using #333, which is the default value for Adaptive Cards host config.

To Reproduce

Steps to reproduce the behavior:

  1. Creates Web Chat with style options { richCardWrapTitle: true }
  2. Shows an Adaptive Card

Expected behavior

The card title should be in black color.

Instead, it is shown in dark gray of #333.

Additional context

[Bug]

@compulim compulim added bug Indicates an unexpected problem or an unintended behavior. Pending labels Nov 6, 2019
@compulim compulim self-assigned this Nov 6, 2019
@corinagum corinagum added the R7 label Nov 6, 2019
@corinagum corinagum removed the Pending label Nov 7, 2019
@corinagum corinagum mentioned this issue Dec 13, 2019
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or an unintended behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants