Fix validateStringMap function #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dmitry-Matveev
approved these changes
Feb 15, 2017
| @@ -140,10 +140,11 @@ class Util { | |||
| var property = obj[field]; | |||
| var propertyType = typeof property; | |||
| if (propertyType !== "string") { | |||
| if (property && typeof property.toString === "function") { | |||
| if (property != null && typeof property.toString === "function") { | |||
There was a problem hiding this comment.
TypeScript wiki seems to want us use undefined.
Was it changed recently or we only care about null here?
There was a problem hiding this comment.
p != null is the same as p !== null && p !== undefined. I wanted to make sure that it's safe to call toString.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #182.
With this change, the
validateStringMapfunction will correctly process properties with number 0 as value. It will also drop invalid values, instead of changing them toinvalid property type: ....