Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Beta] Update Instrumentation Options Type in Docs and Export from Index #1270

Merged
merged 3 commits into from
Feb 1, 2024
Merged

[Beta] Update Instrumentation Options Type in Docs and Export from Index #1270

merged 3 commits into from
Feb 1, 2024

Conversation

JacksonWeber
Copy link
Contributor

@JacksonWeber JacksonWeber commented Jan 30, 2024 •
edited
Loading

AzureMonitorOpenTelemetryOptions extends DistroOptions which contains the InstrumentationOptions interface, which we cannot modify. Therefore we need to cast DistroInstrumentationOptions passed to the shim config by the client to InstrumentationOptions which includes the console and winston instrumentation options.

#1269

hectorhdzg
hectorhdzg approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@hectorhdzg hectorhdzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JacksonWeber JacksonWeber merged commit 305a4d7 into microsoft:beta Feb 1, 2024
5 checks passed
@connormaglynn connormaglynn mentioned this pull request Jun 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hectorhdzg hectorhdzg hectorhdzg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JacksonWeber @hectorhdzg