Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pull request to resolve #73 #121

Merged
merged 6 commits into from
Oct 5, 2016
Merged

Conversation

gzepeda
Copy link
Contributor

@gzepeda gzepeda commented Oct 4, 2016

  • Changed the definition of the trackException method to have the additional parameter
  • Changed the definition of the getExceptionData method to consider the measurements parameter
  • No need to change the Exception Data Contract since it already had a measurements property
  • Adding tests to verify calls to track exception with properties and calls to track properties and measurements

Not sure how to exclude previous commits out there

Kamil Szostak and others added 6 commits September 2, 2016 10:12
Updating my Fork with the current state of Master
- Changed the definition of the trackException method to have the additional parameter
- Changed the definition of the getExceptionData method to consider the measurements parameter
- No need to change the Exception Data Contract since it already had a measurements property
@gzepeda
Copy link
Contributor Author

gzepeda commented Oct 4, 2016

I included some commits that were out there, I did not find the option to exclude them from the pull request.

@gzepeda
Copy link
Contributor Author

gzepeda commented Oct 4, 2016

This is for issue #73

@KamilSzostak
Copy link

:shipit:

@KamilSzostak KamilSzostak added this to the v0.15.20 milestone Oct 4, 2016
@KamilSzostak
Copy link

Previous commits are showing up because they are only in a master branch and I forgot to merge them back to the develop branch. Let's merge them back to develop.

Thanks!

@KamilSzostak KamilSzostak merged commit f756083 into microsoft:develop Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants