Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamic set of Tags support (feature nice to have) #1996

Closed
qyc-dd opened this issue Apr 15, 2020 · 4 comments
Closed

dynamic set of Tags support (feature nice to have) #1996

qyc-dd opened this issue Apr 15, 2020 · 4 comments
Labels
closed-as-inactive question A user question, probably better suited for StackOverflow

Comments

@qyc-dd
Copy link

qyc-dd commented Apr 15, 2020

Wavefront does support different set of tags for the same metric.
I understand there is a limitation of prometheus that it doesn't allow different set of tags.
Is it possible that we can disable that validation controlled by a parameter?

It is not possible that for every metric we can well define all the tags before hand. And we're constantly changing the names of metrics all the time due to adding new tags.
This would be a great feature nice to have and for better control.

Thanks.

@jkschneider
Copy link
Contributor

@qyc-dd Micrometer doesn't actually perform this validation, and does in fact allow for different tags for the same metric name.

For all out-of-the-box instrumentation we try to ensure consistent tags for maximum portability, and because we know Prometheus is popular. But the contract doesn't require it. My hope is that eventually Prometheus drops this requirement, though I'm not holding my breath.

@jkschneider jkschneider added the question A user question, probably better suited for StackOverflow label May 7, 2020
@akibabu
Copy link

akibabu commented Jul 20, 2020

I'm not 100% sure this is the same question but.

@jkschneider Is it a requirement in Prometheus?
We are now running a patched version removing this piece of code and it seems to be working fine.
Both scraping the actuator endpoint and the Pushgateway client.

Inspired by this answer #877 (comment)

But that answer creates a new Collector for each set of tags (and by that a Prometheus TYPE/HELP group) which works for the actuator but returns a 400 from the pushgateway. Instead we reuse the collector for a meter name and add let the original code add the new meters as children.

@marcingrzejszczak marcingrzejszczak added the waiting for feedback We need additional information before we can continue label Dec 20, 2023
Copy link

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

Copy link

github-actions bot commented Jan 4, 2024

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 4, 2024
@jonatan-ivanov jonatan-ivanov removed waiting for feedback We need additional information before we can continue feedback-reminder labels Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-as-inactive question A user question, probably better suited for StackOverflow
Projects
None yet
Development

No branches or pull requests

5 participants