-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dynamic set of Tags support (feature nice to have) #1996
Comments
@qyc-dd Micrometer doesn't actually perform this validation, and does in fact allow for different tags for the same metric name. For all out-of-the-box instrumentation we try to ensure consistent tags for maximum portability, and because we know Prometheus is popular. But the contract doesn't require it. My hope is that eventually Prometheus drops this requirement, though I'm not holding my breath. |
I'm not 100% sure this is the same question but. @jkschneider Is it a requirement in Prometheus? Inspired by this answer #877 (comment) But that answer creates a new Collector for each set of tags (and by that a Prometheus TYPE/HELP group) which works for the actuator but returns a 400 from the pushgateway. Instead we reuse the collector for a meter name and add let the original code add the new meters as children. |
If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed. |
Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open. |
Wavefront does support different set of tags for the same metric.
I understand there is a limitation of prometheus that it doesn't allow different set of tags.
Is it possible that we can disable that validation controlled by a parameter?
It is not possible that for every metric we can well define all the tags before hand. And we're constantly changing the names of metrics all the time due to adding new tags.
This would be a great feature nice to have and for better control.
Thanks.
The text was updated successfully, but these errors were encountered: