-
Notifications
You must be signed in to change notification settings - Fork 9
Deprecate sample_state_information
slot
#2354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Two requested changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise a good PR
@@ -3,7 +3,6 @@ | |||
# type: nmdc:QuantityValue | |||
# has_unit: percent | |||
# has_numeric_value: 10 | |||
#sample_state_information: liquid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@turbomam what's up with this example? Was it just never finished?
Reassigning to @eecavanna to plan the migrator. |
Now that (i.e. as of commit 2c9c250 on this branch) instances of the In the schema docs, I can see that the
The migrator will locate each "instance" of each of those classes in the database, check whether it has a |
@eecavanna note that there will not be instances of |
Thanks, @kheal! In search of instances of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This migrator is not being introduced via this PR. It is only being moved (and its _from_version
/_to_version
modified).
This migrator was introduced via PR #2413. There, its location was nmdc_schema/migrators/migrator_from_11_5_1_to_11_6_0.py
.
In this PR, it is being moved (and its _from_version
/_to_version
modified) to be a "partial" migrator, since there are now multiple migrators involved between the two schema versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only migrator being introduced to accompany this schema change.
...a/migrators/partials/migrator_from_11_5_1_to_11_6_0/migrator_from_11_5_1_to_11_6_0_part_1.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eecavanna - I reviewed the migrator. The logic, methods, and tests all look great to me. Thank you for the thorough documentation.
@turbomam @eecavanna @sierra-moxon |
@mslarae13 the check failed because the computer (one of GitHub's servers) that runs the check failed to install some Python packages. I think it's a transient failure unrelated to the changes on this branch. I've launched a re-run of the check. |
sample_state_information
slot
discussions in the mass spec material processing squad
this slot shouldn't be on
PortionOfSubstance
and there's no indication that it's relevant to NMDC