Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul images and tags implementation #14

Open
mgax opened this issue Oct 27, 2022 · 0 comments
Open

Overhaul images and tags implementation #14

mgax opened this issue Oct 27, 2022 · 0 comments

Comments

@mgax
Copy link
Owner

mgax commented Oct 27, 2022

The images/tags code is a bit of a mess. Tags were initially supposed to work transparently, hence were implemented as symlinks, but that's actually not helpful, because a VM should always point to the same immutable base image from which it was created, so the link is dereferenced anyway. Some things that could use fixing:

  • Keep images and tags in separate directories. Tags should be regular files that contain the image's ID.
  • Images should have an id rather than a name; the expectation for a name is that it's human-friendly, but they are sha256 hashes.
  • Validate inputs (Tag images command; improve untag command #11 (comment)).
  • Allow the user to specify any unique prefix of an image id, so that it's possible to copy/paste the output of miv images and miv build into a new command.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant