Dispose IHtmlDocument objects (fixes #396)

mganss · mganss · commit 4347747242ca · 2022-10-12T18:24:41.000+02:00
diff --git a/src/HtmlSanitizer/HtmlSanitizer.cs b/src/HtmlSanitizer/HtmlSanitizer.cs
@@ -406,7 +406,7 @@ public IHtmlDocument SanitizeDom(IHtmlDocument document, IHtmlElement? context =
         public string SanitizeDocument(string html, string baseUrl = "", IMarkupFormatter? outputFormatter = null)
         {
             var parser = HtmlParserFactory();
-            var dom = parser.ParseDocument(html);
+            using var dom = parser.ParseDocument(html);
 
             DoSanitize(dom, dom, baseUrl);
 
@@ -425,7 +425,7 @@ public string SanitizeDocument(string html, string baseUrl = "", IMarkupFormatte
         public string SanitizeDocument(Stream html, string baseUrl = "", IMarkupFormatter? outputFormatter = null)
         {
             var parser = HtmlParserFactory();
-            var dom = parser.ParseDocument(html);
+            using var dom = parser.ParseDocument(html);
 
             DoSanitize(dom, dom, baseUrl);
 

Original file line number	Diff line number	Diff line change
`@@ -406,7 +406,7 @@ public IHtmlDocument SanitizeDom(IHtmlDocument document, IHtmlElement? context =`
`406`	`406`	`public string SanitizeDocument(string html, string baseUrl = "", IMarkupFormatter? outputFormatter = null)`
`407`	`407`	`{`
`408`	`408`	`var parser = HtmlParserFactory();`
`409`		`- var dom = parser.ParseDocument(html);`
	`409`	`+ using var dom = parser.ParseDocument(html);`
`410`	`410`
`411`	`411`	`DoSanitize(dom, dom, baseUrl);`
`412`	`412`
`@@ -425,7 +425,7 @@ public string SanitizeDocument(string html, string baseUrl = "", IMarkupFormatte`
`425`	`425`	`public string SanitizeDocument(Stream html, string baseUrl = "", IMarkupFormatter? outputFormatter = null)`
`426`	`426`	`{`
`427`	`427`	`var parser = HtmlParserFactory();`
`428`		`- var dom = parser.ParseDocument(html);`
	`428`	`+ using var dom = parser.ParseDocument(html);`
`429`	`429`
`430`	`430`	`DoSanitize(dom, dom, baseUrl);`
`431`	`431`