Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poor performance when running with xmi v0.3.13 #335

Open
kwkwan opened this issue Feb 3, 2025 · 4 comments · May be fixed by #336
Open

Poor performance when running with xmi v0.3.13 #335

kwkwan opened this issue Feb 3, 2025 · 4 comments · May be fixed by #336
Assignees
@kwkwan

Comments

@kwkwan
Copy link
Contributor

kwkwan commented Feb 3, 2025

No description provided.

@kwkwan kwkwan self-assigned this Feb 3, 2025
@kwkwan kwkwan linked a pull request Feb 3, 2025 that will close this issue
Workaround to fix poor performance in xmi when using lutaml-model #336
Open
4 tasks
@kwkwan
Copy link
Contributor Author

kwkwan commented Feb 3, 2025

Refer to metanorma/metanorma-plateau#159.

@ReesePlews
Copy link
Contributor

hello @kwkwan thank you for your work on this issue. if you have made a fix that needs checking please tell me how to modify my Gemfile to check with your new branch. thank you.

@kwkwan
Copy link
Contributor Author

kwkwan commented Feb 3, 2025

hello @kwkwan thank you for your work on this issue. if you have made a fix that needs checking please tell me how to modify my Gemfile to check with your new branch. thank you.

Hi @ReesePlews, the proposed changes in the pull request #336. Please review it. Thanks.

@ReesePlews
Copy link
Contributor

ReesePlews commented Feb 3, 2025 •
edited
Loading

hello @kwkwan i compiled locally after adding this line to my Gemfile

gem "xmi", git: "https://github.com/lutaml/xmi", ref: "v0.3.11"

the compile took 1 hour, which is a great improvement over the 3.5 hours a couple of days ago. thank you for fixing this!

i will let you make any final checks before it is merged into the main branch.

@ReesePlews ReesePlews mentioned this issue Feb 19, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kwkwan kwkwan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Workaround to fix poor performance in xmi when using lutaml-model metanorma/mn-samples-plateau
2 participants
@kwkwan @ReesePlews