inherit JIS sorting of references: metanorma/metanorma-jis#205

Author: opoudjis

Gemfile.devel

@@ -0,0 +1 @@
+gem "metanorma-jis", git: "https://github.com/metanorma/metanorma-jis", branch: "fix/refs-ordering"

lib/metanorma/plateau/cleanup.rb

@@ -28,14 +28,15 @@ def blocksource_cleanup(xmldoc)
         super
       end
 
-      def pub_class(bib)
-        return 1 if bib.at("#{PUBLISHER}[name = '#{pub_hash['en']}']") ||
-          bib.at("#{PUBLISHER}[name = '#{pub_hash['ja']}']") ||
-          bib.at("#{PUBLISHER}[abbreviation = 'MLIT']")
-        return 2 if bib["type"] == "standard"
-
-        3
-      end
+      # Abandoned in favour of JIS ordering
+      #       def pub_class(bib)
+      #         return 1 if bib.at("#{PUBLISHER}[name = '#{pub_hash['en']}']") ||
+      #           bib.at("#{PUBLISHER}[name = '#{pub_hash['ja']}']") ||
+      #           bib.at("#{PUBLISHER}[abbreviation = 'MLIT']")
+      #         return 2 if bib["type"] == "standard"
+      #
+      #         3
+      #       end
 
       def biblio_reorder(xmldoc)
         xmldoc.xpath("//references").each do |r|

spec/metanorma/refs_spec.rb

@@ -71,15 +71,15 @@
       out = Nokogiri::XML(Asciidoctor.convert(input, *OPTIONS))
       expect(out.xpath("//xmlns:references/xmlns:bibitem/@id")
         .map(&:value))
-        .to be_equivalent_to ["ref4", "ref1", "ref2", "ref5", "ref3", "ref6"]
+        .to be_equivalent_to ["ref3", "ref6", "ref5", "ref2", "ref4", "ref1"]
     end
 
     VCR.use_cassette "sortrefs" do
       out = Nokogiri::XML(Asciidoctor.convert(input
         .sub("== Bibliography", "== Normative References"), *OPTIONS))
       expect(out.xpath("//xmlns:references/xmlns:bibitem/@id")
         .map(&:value))
-        .to be_equivalent_to ["ref4", "ref1", "ref2", "ref5", "ref3", "ref6"]
+        .to be_equivalent_to ["ref3", "ref6", "ref5", "ref2", "ref4", "ref1"]
     end
   end
 end