refactor i18n yaml to prevent overwriting parent non-English YAML with local English file: metanorma/isodoc#549

Author: opoudjis

Gemfile.devel

@@ -1,2 +1,2 @@
-gem "isodoc", git: "https://github.com/metanorma/isodoc", branch: "fix/recursive-prefix-container"
-gem "metanorma-iso", git: "https://github.com/metanorma/metanorma-iso", branch: "fix/recursive-prefix-container"
+gem "isodoc", git: "https://github.com/metanorma/isodoc", branch: "fix/i18n-yaml-inheritance"
+gem "metanorma-iso", git: "https://github.com/metanorma/metanorma-iso", branch: "fix/i18n-yaml-inheritance"

lib/isodoc/jis/i18n.rb

@@ -1,15 +1,15 @@
 module IsoDoc
   module JIS
     class I18n < IsoDoc::Iso::I18n
+      def load_file(fname)
+        f = File.join(File.dirname(__FILE__), fname)
+        File.exist?(f) ? YAML.load_file(f) : {}
+      end
+
       def load_yaml1(lang, script)
-        y = if lang == "en"
-              YAML.load_file(File.join(File.dirname(__FILE__), "i18n-en.yaml"))
-            else
-              YAML.load_file(File.join(File.dirname(__FILE__), "i18n-ja.yaml"))
-            end
-        super.deep_merge(y)
+        y = load_file("i18n-#{yaml_lang(lang, script)}.yaml")
+        y.empty? ? load_file("i18n-en.yaml").merge(super) : super.deep_merge(y)
       end
     end
   end
 end
-