Skip to content

Commit a3c7ad4

Browse files
authored
Merge pull request #119 from metanorma/fix/doctype-attribute
metanorma/metanorma-standoc#817
2 parents c53558c + 24d38d5 commit a3c7ad4

File tree

5 files changed

+167
-164
lines changed

5 files changed

+167
-164
lines changed

Gemfile.devel

+4
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
gem "metanorma-standoc", git: "https://github.com/metanorma/metanorma-standoc", branch: "fix/doctype-attribute"
2+
gem "metanorma-iso", git: "https://github.com/metanorma/metanorma-iso", branch: "fix/doctype-attribute"
3+
gem "isodoc", git: "https://github.com/metanorma/isodoc", branch: "main"
4+

lib/metanorma/jis/validate.rb

+3-4
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,11 @@
11
module Metanorma
22
module JIS
33
class Converter < ISO::Converter
4-
def doctype_validate(xmldoc)
5-
doctype = xmldoc&.at("//bibdata/ext/doctype")&.text
4+
def doctype_validate(_xmldoc)
65
%w(japanese-industrial-standard technical-report
7-
technical-specification amendment).include? doctype or
6+
technical-specification amendment).include? @doctype or
87
@log.add("Document Attributes", nil,
9-
"#{doctype} is not a recognised document type")
8+
"#{@doctype} is not a recognised document type")
109
end
1110

1211
def script_validate(xmldoc)

spec/vcr_cassettes/isobib_123_dated.yml

+62-62
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

spec/vcr_cassettes/isobib_123_mix_dated.yml

+61-61
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

spec/vcr_cassettes/isobib_123_undated.yml

+37-37
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)