Skip to content

Commit 984193e

Browse files
authored
Merge pull request #145 from metanorma/fix/empty-params-pubid
do not pass empty parameters to pubid: https://github.com/metanorma/m…
2 parents 71aa816 + afb2c75 commit 984193e

File tree

2 files changed

+11
-10
lines changed

2 files changed

+11
-10
lines changed

Gemfile.devel

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
gem "metanorma-iso", git: "https://github.com/metanorma/metanorma-iso", branch: "main"

lib/metanorma/jis/front.rb

+10-10
Original file line numberDiff line numberDiff line change
@@ -68,17 +68,16 @@ def multiling_docattr(node, attr, suffix, langs)
6868
ret = node.attr(attr + suffix) and return ret
6969
ret = langs.each_with_object({}).each do |l, m|
7070
x = node.attr("#{attr}-#{l}#{suffix}") and m[l] = x
71-
end.compact
71+
end
7272
ret.empty? and return nil
73-
ret
73+
compact_blank(ret)
7474
end
7575

7676
def extract_org_attrs_complex(node, opts, source, suffix)
77-
{ name: multiling_docattr(node, source, suffix, LANGS),
78-
role: opts[:role], desc: opts[:desc],
79-
abbr: multiling_docattr(node, "#{source}-abbr", suffix, LANGS),
80-
logo: multiling_docattr(node, "#{source}_logo", suffix, LANGS) }
81-
.compact
77+
compact_blank({ name: multiling_docattr(node, source, suffix, LANGS),
78+
role: opts[:role], desc: opts[:desc],
79+
abbr: multiling_docattr(node, "#{source}-abbr", suffix, LANGS),
80+
logo: multiling_docattr(node, "#{source}_logo", suffix, LANGS) })
8281
.merge(extract_org_attrs_address(node, opts, suffix))
8382
end
8483

@@ -168,12 +167,13 @@ def iso_id_params_core(node)
168167
publisher: pub[0],
169168
copublisher: pub[1..-1] }.compact
170169
ret[:copublisher].empty? and ret.delete(:copublisher)
171-
ret
170+
compact_blank(ret)
172171
end
173172

174173
def iso_id_params_add(node)
175-
{ number: node.attr("amendment-number"),
176-
year: iso_id_year(node) }.compact
174+
ret = { number: node.attr("amendment-number"),
175+
year: iso_id_year(node) }
176+
compact_blank(ret)
177177
end
178178

179179
def iso_id_out(xml, params, _with_prf)

0 commit comments

Comments
 (0)