validate editorial groups within gem: closes relaton/relaton-iho#2

Author: opoudjis

lib/asciidoctor/iho/biblio.rng

@@ -661,9 +661,9 @@
     <optional>
       <ref name="status"/>
     </optional>
-    <optional>
+    <zeroOrMore>
       <ref name="copyright"/>
-    </optional>
+    </zeroOrMore>
     <zeroOrMore>
       <ref name="docrelation"/>
     </zeroOrMore>
@@ -1024,6 +1024,14 @@
       <oneOrMore>
         <ref name="owner"/>
       </oneOrMore>
+      <optional>
+        <ref name="copyright_scope"/>
+      </optional>
+    </element>
+  </define>
+  <define name="copyright_scope">
+    <element name="scope">
+      <text/>
     </element>
   </define>
   <define name="from">

lib/asciidoctor/iho/converter.rb

@@ -58,7 +58,14 @@ def metadata_commentperiod(node, xml)
       end
 
       def metadata_committee(node, xml)
-        return unless node.attr("workgroup")
+        unless node.attr("workgroup")
+          @log.add("AsciiDoc Input", nil, "Missing workgroup attribute for document")
+          return
+        end
+        metadata_committee1(node, xml)
+      end
+
+      def metadata_committee1(node, xml)
         xml.editorialgroup do |a|
           a.committee node.attr("committee")
           a.workgroup node.attr("workgroup")

lib/asciidoctor/iho/iho.rng

@@ -31,9 +31,9 @@
       <optional>
         <ref name="doctype"/>
       </optional>
-      <oneOrMore>
+      <zeroOrMore>
         <ref name="editorialgroup"/>
-      </oneOrMore>
+      </zeroOrMore>
       <zeroOrMore>
         <ref name="ics"/>
       </zeroOrMore>

spec/asciidoctor/validate_spec.rb

@@ -0,0 +1,19 @@
+require "spec_helper"
+
+RSpec.describe Asciidoctor::IHO do
+
+  it "warns about missing workgroup" do
+  FileUtils.rm_f "test.err"
+  Asciidoctor.convert(<<~"INPUT", backend: :iho, header_footer: true)
+  #{VALIDATING_BLANK_HDR}
+
+  == Clause 1
+
+  Subclause
+  INPUT
+  expect(File.read("test.err")).to include "Missing workgroup attribute for document"
+  end
+
+
+end
+