Skip to content
This repository was archived by the owner on Oct 30, 2022. It is now read-only.

Commit d051cd8

Browse files
committed
Docs: Removed condescending language
1 parent d26272b commit d051cd8

File tree

5 files changed

+7
-7
lines changed

5 files changed

+7
-7
lines changed

CONTRIBUTING.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ All of our releases are automated using [semantic-release](https://github.com/se
121121

122122
## GitHub Apps
123123

124-
We use several GitHub apps to help maintain this repository. While we would like to address every issue and while we would like to be on hand to support every person, unmock is pretty much entirely volunteer run, and we simply don't have the time to do everything. Please don't be offended if an automated app posts in your issue! We're doing what we can with with we have.
124+
We use several GitHub apps to help maintain this repository. While we would like to address every issue and while we would like to be on hand to support every person, unmock is pretty much entirely volunteer run, and we don't have the time to do everything. Please don't be offended if an automated app posts in your issue! We're doing what we can with with we have.
125125

126126
Currently, we use the [Stale](https://github.com/apps/stale) and [Lock](https://github.com/apps/lock) apps to mark old issues as stale, and to lock issues which have been closed to stop drive-by comments. You can see the configuration files for these in [.github/](.github).
127127

@@ -137,7 +137,7 @@ Here are some things you can do today to actively show the unmock team that you'
137137
- **Review PRs.** We have a lot of open PRs! Some of these are probably ready to merge, and some of them probably need more work. Any extra eyes on PRs are encouraged. Comment on code patterns you think need work, suggest extra tests, and let us know if a PR 'LGTM' ("looks good to me"). The more reviewers we have, the faster we can merge issues, the better this project becomes.
138138
- **Help out!** If someone files a bug and no one has responded yet, see if you can resolve it! Suggest PRs, or file them yourself. While most contributors are going to only be interested in their own bugs, great maintainers help out with other people's bugs. This is one of the best ways to become an expert at unmock (and Node.js, JavaScript, or pretty much any project) - helping others.
139139
- **Write docs.** Are our docs missing something important? Are they not clear? Could they be better? Open a PR!
140-
- **Suggest examples.** Right now, we have a few examples, but we could always have more. Submit small example files and tutorials. At some point, we'll have to work on a better way to display these - for now, it's great to show others how to solve difficult mocking problems easily with unmock.
140+
- **Suggest examples.** Right now, we have a few examples, but we could always have more. Submit small example files and tutorials. At some point, we'll have to work on a better way to display these - for now, it's great to show others how to solve difficult mocking problems with unmock.
141141
- **Refactor.** This is one of the hardest things to do, but one of the most useful. Go through the code, and find examples where it could be written better - with better variable names, more useful abstractions, and more elegant patterns. Taking away ten lines of code that are unnecessary is more valuable than submitting a hundred new lines, sometimes. Open a PR or a comment and defend your position; ask for feedback.
142142

143143
Once you've been around for a bit, ask a current Maintainer - one of [the team members](https://github.com/orgs/unmock/people) - whether you can be elevated to Maintainer status and given permissions to close issues and merge PRs. We're interested in how well you know what unmock is about, and how involved you are in the community - not where you're from, how good your English is, or whether or not you can pass a whiteboard test blindfolded. If you think that you've been helpful, let us know. We're friendly, promise. :)

README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ $ npm install --save-dev unmock
3636

3737
This README contains all the essential information about unmock. For more examples an in-depth explanations, see the [documentation](https://unmock.io/docs/introduction).
3838

39-
Here is a simple mock, a simple function, and a simple test in jest.
39+
Here is a mock, a function, and a test in jest.
4040

4141
```js
4242
const unmock = require("unmock");
@@ -363,7 +363,7 @@ test("my API always works as expected", runner(async () => {
363363
364364
## OpenAPI
365365
366-
Unmock supports the reading of OpenAPI specifications out of the box. Simply place your specification in a folder at the root of your project called `__unmock__/<myspecname>`, where `<myspecname>` is the name of the spec on the `unmock.on().services` object. Several examples of this exist on the internet, most notably [here](https://github.com/unmock/unmock-examples/tree/master/using-service-repository).
366+
Unmock supports the reading of OpenAPI specifications out of the box. Place your specification in a folder at the root of your project called `__unmock__/<myspecname>`, where `<myspecname>` is the name of the spec on the `unmock.on().services` object. Several examples of this exist on the internet, most notably [here](https://github.com/unmock/unmock-examples/tree/master/using-service-repository).
367367
368368
## Tutorials
369369

packages/unmock-core/src/__tests__/backend/state.test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ describe("Node.js interceptor", () => {
165165
expect(response.data).toBe("petstore.swagger.io");
166166
});
167167

168-
// this is just a no-op in the new version
168+
// this is a no-op in the new version
169169
test("fails setting an array size for non-array elements", async () => {
170170
petstore.state(
171171
withCodes(200),

packages/unmock-core/src/generator.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -669,7 +669,7 @@ const toSchema = toSchemas.composeLens(valueLens());
669669
* - there is at most one path item in the schema
670670
* - there is at most one operation in the path item
671671
* It will still work if this is not the case, but it will
672-
* just pick a random schema, path item and operation, which
672+
* pick a random schema, path item and operation, which
673673
* will lead to nonsensical results.
674674
* @param schemaRecord the Record<string, OpenAPISchema> that we
675675
* are getting the operation from.

packages/unmock-core/src/service/serviceStore.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ export class ServiceStore {
4747
this.cores[hostName] !== undefined &&
4848
this.cores[serviceName] === undefined
4949
) {
50-
// remove old service core and wrapper if a service is just renamed
50+
// remove old service core and wrapper if a service is renamed
5151
delete this.cores[hostName];
5252
delete this.services[hostName];
5353
}

0 commit comments

Comments
 (0)