Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use snake-case for field names in did.proto #170

Closed
youngjoon-lee opened this issue Jul 8, 2021 · 0 comments · Fixed by #171
Closed

Use snake-case for field names in did.proto #170

youngjoon-lee opened this issue Jul 8, 2021 · 0 comments · Fixed by #171
Assignees
@youngjoon-lee
Milestone
v2.0.0

Comments

@youngjoon-lee
Copy link
Contributor

This is a post-issue of the PR #166 .

The did.proto still has camel-case field names in order to obey the W3C DID spec.
But, the snake-case is the protobuf standard, and we already rely on the json_name tag. So, it wouldn't be a problem.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@youngjoon-lee youngjoon-lee

Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

fix: Use snake-case for did.proto + proto lint fixes medibloc/panacea-core
1 participant
@youngjoon-lee