Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Organize sandbox attribute values; add missing sandbox values #18862

Merged
merged 3 commits into from
Apr 24, 2023
Merged

Organize sandbox attribute values; add missing sandbox values #18862

merged 3 commits into from
Apr 24, 2023

Conversation

queengooborg
Copy link
Contributor

This PR organizes the sandbox attribute values of the iframe HTML element, as well as adds the missing attribute values. Fixes #1208.

@github-actions github-actions bot added the data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML label Feb 9, 2023
@queengooborg queengooborg requested a review from Elchi3 April 6, 2023 07:04
Elchi3
Elchi3 reviewed Apr 11, 2023
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for fixing this really old request!
Can you add spec_urls to all of them? I think it would be useful

@queengooborg
Copy link
Contributor Author

Spec URLs added!

I also found that allow-downloads-without-user-activation isn't defined in the spec. I'm assuming that it was originally in the spec but then removed, so I've marked it as deprecated as well.

@Elchi3
Copy link
Member

Elchi3 commented Apr 24, 2023

I also found that allow-downloads-without-user-activation isn't defined in the spec. I'm assuming that it was originally in the spec but then removed, so I've marked it as deprecated as well.

Yeah, I couldn't find what's the story here. There is https://github.com/w3c/webappsec-permissions-policy/blob/main/sandbox.md but I don't see it in a specification.

@Elchi3 Elchi3 merged commit d53fde8 into mdn:main Apr 24, 2023
@queengooborg queengooborg deleted the html/elements/iframe/sandbox branch April 24, 2023 08:53
@Sjord
Copy link
Contributor

Sjord commented Jun 4, 2024

I am thinking about removing allow-downloads-without-user-activation, since it is not in the spec anymore and isn't implemented by any browser. I want to remove it from the MDN docs, and apparently it also needs to be removed from the compatibility table. Does this make sense?

@Sjord Sjord mentioned this pull request Jun 4, 2024
Merged
@Elchi3
Copy link
Member

Elchi3 commented Jun 4, 2024

Yes, I think that makes sense. I found https://chromestatus.com/feature/5706745674465280 which says it was removed in Chromium 83. Do you want to create a PR that removes the data?

@Sjord Sjord mentioned this pull request Jun 4, 2024
Merged
@Sjord
Copy link
Contributor

Sjord commented Jun 4, 2024

Remove allow-downloads-without-user-activation by Sjord · Pull Request #23253 · mdn/browser-compat-data

Elchi3 pushed a commit that referenced this pull request Jun 4, 2024
@Sjord
Remove allow-downloads-without-user-activation (#23253)
8dd59de 
It is not currently supported by any browser. This was implemented in Chrome at one time, but has been removed. No browser seems to support this currently. There is an open issue with a request to implement this, but that does not seem very active.

Related to:
- #18862
- mdn/content#33409
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

List all sandbox attribute values
3 participants
@queengooborg @Elchi3 @Sjord